Link to libexecinfo on BSD always, not just in a debug compiler #2916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ponylang#2826 restricted -lexecinfo to debug compilers (not even to building something in debug mode). This doesn't make much sense. I'm not sure why ordinary builds can succeed without -lexecinfo, but bitcode-runtime builds can't. Either way, if it's always included on non-glibc-Linux, it should always be included on BSD.
jemc
approved these changes
Oct 30, 2018
|
@slfritchie do you have any input on this? |
|
No, @aturley, I don't. If @myfreeweb says it ought to be included, I'm inclined to accept. |
|
Rerunning CI to try to see if they'll pass. When they do, this is ready to merge. |
|
looks like an intermittent qemu segfault on cross-llvm-391-debug-armhf |
jemc
added
the
changelog - fixed
|
Okay, I'm merging anyway... |
ponylang-main
added a commit
that referenced
this pull request
Nov 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2826 restricted -lexecinfo to debug compilers (not even to building something in debug mode).
This doesn't make much sense. I'm not sure why ordinary builds can succeed without -lexecinfo, but bitcode-runtime builds can't. Either way, if it's always included on non-glibc-Linux, it should always be included on BSD.