-
-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix static linking issue encountered during stable build #3259
Conversation
@SeanTAllen it would be ideal if you were able to test with these changes prior to merging. In my limited testing, when using |
@dipinhora what should the |
@SeanTAllen depends on your environment. Most have |
@dipinhora circleci tests arent running for some reason for this PR (and for your last one). Not sure why. |
@SeanTAllen they're running. They are linked to my personal circleci account setup so they don't show on the PR. It's very annoying actually. |
@dipinhora that's weird and new. @EpicEric opened a PR earlier from a forked repo and it showed up here. |
@SeanTAllen re: circleci... i was wrong.. they used to run.. now they're stuck with a "needs setup" (see: https://circleci.com/gh/dipinhora/workflows/ponyc). Very annoying. I'll do a force push to get circleci to pick it up as part of the PR so it works correctly I hope. |
@dipinhora you might need to turn on using version 2.1/pipeline features under advanced settings for them to work. |
@SeanTAllen re: PRs from other folks. It depends on whether they have circleci setup to do their own personal building outside of the ponylang PRs or not. It's a very annoying quirk. |
@SeanTAllen is this error (https://circleci.com/gh/dipinhora/ponyc/9449; note, this is on a test branch) expected after turning on the pipeline feature thing? |
@dipinhora you'll apparently need to turn on the orb feature as well. For the ponylang org, its under the org settings under "Security". |
@SeanTAllen new error: https://circleci.com/gh/dipinhora/ponyc/9451. I think I'm going to delete the ponyc project from my circleci config so PRs work again and maybe figure this out at some point in the future. |
@SeanTAllen it seems my deleting |
@SeanTAllen nevermind. spoke too soon. any idea how to fix that error? |
f48f313
to
22a59bb
Compare
Thanks @dipinhora |
Ensure that
-latomic
comes after-static
to fix static linkingAllow overriding
-fuse-ld
command for linking