Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile fix for the latest MSVC compiler (MSVC 19.26.28806.0, from Visual Studio 16.6.2) #3576

Merged
merged 2 commits into from
Jun 22, 2020

Conversation

chalcolith
Copy link
Member

Adds an explicit constructor to pool_block_t . Without the explicit constructor, the compiler says "attempting to reference a deleted function", referring to the auto-created constructor.

…icrosoft compiler.

Without the explicit constructor, the compiler says "attempting to reference a deleted function", referring to the auto-created constructor.
@chalcolith chalcolith requested a review from mfelsche June 18, 2020 15:11
Copy link
Contributor

@mfelsche mfelsche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am in no position to judge this change. But if CI is good, I am good too.
Do we test against this latest MSVC compiler?

@SeanTAllen
Copy link
Member

I think this is worth a changelog entry. @kulibali which one is most appropriate?

Also @kulibali what is the latest MSVC, for historical purposes, can we be more explicit with the PR and changelog entry title?

@chalcolith chalcolith changed the title Compile fix for the latest MSVC compiler Compile fix for the latest MSVC compiler (MSVC 19.26.28806.0, from Visual Studio 16.6.2) Jun 19, 2020
@chalcolith
Copy link
Member Author

@SeanTAllen should I squash/amend the commits for the changelog message, or does it pick up the PR description?

@SeanTAllen
Copy link
Member

It picks up from PR description

@chalcolith chalcolith added the changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge label Jun 19, 2020
@chalcolith chalcolith merged commit 6d3d2c9 into master Jun 22, 2020
@chalcolith chalcolith deleted the vs_compiler_fix branch June 22, 2020 14:56
github-actions bot pushed a commit that referenced this pull request Jun 22, 2020
@damon-kwok
Copy link
Contributor

damon-kwok commented Jun 22, 2020

Awesome
This merge solves problem-2 in #3544

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants