Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building libs with Visual Studio 16.7 #3635

Merged
merged 2 commits into from
Sep 1, 2020
Merged

Fix building libs with Visual Studio 16.7 #3635

merged 2 commits into from
Sep 1, 2020

Conversation

chalcolith
Copy link
Member

Visual Studio 16.7 introduced a change in C++20 compatibility that breaks building LLVM on Windows (#3634). This change adds a patch for LLVM that fixes the issue. Fixes #3634.

The change also introduces a check in CMake of the hashes of the patch files. Since the build caches in CI depend on the contents of libs/CMakeLists.txt, and that file contains the desired hash, changing the patches (and thus the desired hash) will force a rebuild of the libs build caches (in the same way as changing the Git checkout for LLVM will force a rebuild).

Visual Studio 16.7 introduced a change in C++20 compatibility that breaks building LLVM on Windows (#3634).  This change adds a patch for LLVM that fixes the issue.  Fixes #3634.

The change also introduces a check in CMake of the hashes of the patch files. Since the build caches in CI depend on the contents of `libs/CMakeLists.txt`, and that file contains the desired hash, changing the patches (and thus the desired hash) will force a rebuild of the libs build caches (in the same way as changing the Git checkout for LLVM will force a rebuild).
@chalcolith chalcolith added the changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge label Sep 1, 2020
@ponylang-main
Copy link
Contributor

Hi @kulibali,

The changelog - fixed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do.

Release notes are added by creating a uniquely named file in the .release-notes directory. We suggest you call the file 3635.md to match the number of this pull request.

The basic format of the release notes (using markdown) should be:

## Title

End user description of changes, why it's important,
problems it solves etc.

If a breaking change, make sure to include 1 or more
examples what code would look like prior to this change
and how to update it to work after this change.

Thanks.

@SeanTAllen SeanTAllen merged commit 11ff32d into master Sep 1, 2020
@SeanTAllen SeanTAllen deleted the fix_msvc_16_7 branch September 1, 2020 18:02
@SeanTAllen
Copy link
Member

Thanks @kulibali.

github-actions bot pushed a commit that referenced this pull request Sep 1, 2020
github-actions bot pushed a commit that referenced this pull request Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make.ps1 libs fails on Visual Studio 16.7.2
3 participants