Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link errors on macOS Big Sur #3686

Merged
merged 2 commits into from
Dec 20, 2020
Merged

Fix link errors on macOS Big Sur #3686

merged 2 commits into from
Dec 20, 2020

Conversation

ergl
Copy link
Member

@ergl ergl commented Dec 19, 2020

With the change from Catalina to Big Sur, Apple moved the location of
libraries. On Big Sur, it is required to pass the location of the System
library. The -lSystem option is still required for macOS 10.15.7 and
lower.

We don't currently distinguish between different macOS versions, so we
should keep both options. As long as the absolute path of the System
library is present, the -lSystem option won't pose any problems on Big
Sur.

This should fix #3684.

With the change from Catalina to Big Sur, Apple moved the location of
libraries. On Big Sur, it is required to pass the location of the System
library. The `-lSystem` option is still required for macOS 10.15.7 and
lower.

We don't currently distinguish between different macOS versions, so we
should keep both options. As long as the absolute path of the System
library is present, the `-lSystem` option won't pose any problems on Big
Sur.
@ergl
Copy link
Member Author

ergl commented Dec 19, 2020

As for keeping -lSystem around: ponyc failed to link on Mojave if I removed the option.

@SeanTAllen SeanTAllen added the changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge label Dec 19, 2020
@ponylang-main
Copy link
Contributor

Hi @ergl,

The changelog - fixed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do.

Release notes are added by creating a uniquely named file in the .release-notes directory. We suggest you call the file 3686.md to match the number of this pull request.

The basic format of the release notes (using markdown) should be:

## Title

End user description of changes, why it's important,
problems it solves etc.

If a breaking change, make sure to include 1 or more
examples what code would look like prior to this change
and how to update it to work after this change.

Thanks.

@SeanTAllen SeanTAllen mentioned this pull request Dec 19, 2020
@SeanTAllen SeanTAllen merged commit 75c0299 into ponylang:master Dec 20, 2020
@SeanTAllen
Copy link
Member

Thanks @ergl.

github-actions bot pushed a commit that referenced this pull request Dec 20, 2020
github-actions bot pushed a commit that referenced this pull request Dec 20, 2020
@ergl ergl deleted the fix-3684 branch December 21, 2020 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error "ld: library not found for -lSystem" on macOS Big Sur
3 participants