Remove libponyc's link dependency on blake2 library. #3715
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to use libponyc from a pony program I ran into two linking problems. Both libblake2 and llvm are required to resolve symbols in libponyc. Handling all the LLVM dependencies is large issue, addressing the libblake dependency is much simpler. This commit moves libblake from being a library that gets built as a `.a` and instead links its `.o` directly into libponyc. This change along with a much larger change to address the LLVM dependency should make it possibly to easily include libponyc into pony programs via C-FFI.
SeanTAllen
force-pushed
the
inline-blake2
branch
from
eac5a1a to
efaf427
Compare
|
Closing in favor of #3716. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to use libponyc from a pony program I ran into two linking
problems. Both libblake2 and llvm are required to resolve symbols in
libponyc.
Handling all the LLVM dependencies is large issue, addressing the
libblake dependency is much simpler.
This commit moves libblake from being a library that gets built as a
.aand instead links its.odirectly into libponyc.This change along with a much larger change to address the LLVM dependency
should make it possibly to easily include libponyc into pony programs
via C-FFI.