Fix compiler crash related to type parameter references #3725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug in rescoping. Rescoping happens after a method was copied from a trait/interface to another type. It starts with a fresh scope, visits all of the method's AST nodes and adds the visited symbols to the method's symbol table. This includes type parameters. If a type parameter reference is visited, the referenced type parameter is looked up and added as data to the node. As rescoping starts with a fresh scope, adding the type parameter to the reference fails if the type parameter itself is not defined yet. This is fixed by eagerly adding type parameters to the scope before visiting type parameter references. Fixes ponylang#3285
SeanTAllen
added
the
changelog - fixed
SeanTAllen
approved these changes
Feb 28, 2021
|
@Trundle you are making me smile so much lately. thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in rescoping. Rescoping happens after a method was
copied from a trait/interface to another type. It starts with a fresh
scope, visits all of the method's AST nodes and adds the visited symbols
to the method's symbol table. This includes type parameters. If a type
parameter reference is visited, the referenced type parameter is looked
up and added as data to the node.
As rescoping starts with a fresh scope, adding the type parameter to the
reference fails if the type parameter itself is not defined yet. This is
fixed by eagerly adding type parameters to the scope before visiting
type parameter references.
Fixes #3285