Fix literal inference through partial function #3729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, code such as `1~add(2)` would hit an assertion error when the compiler tried to infer the type of the literal `2`. The compiler tries to find the type of the receiver of the function, in this case `1`, but it lacked the ability to do so when using partial functions. In those cases, the compiler would try to look at the type of the `~` token, which is not a valid value literal, and as such it would fail.
ergl
force-pushed
the
fix_partial_literal_inference
branch
from
53b6715 to
b147a1a
Compare
SeanTAllen
added
the
changelog - fixed
SeanTAllen
approved these changes
Mar 11, 2021
| @@ -0,0 +1,3 @@ | |||
| ## Fix literal inference with partial functions | |||
|
|
|||
| Before this change, code such as `1~add(2)` would hit an assertion error when the compiler tried to infer the type of the literal `2`. The compiler tries to find the type of the receiver of the function (in this case `1`), but before it lacked the ability to do so when using partial functions. In those cases, the compiler would try to look at the type of the `~` token, which is not a valid value literal, and as such it would fail. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, code such as
1~add(2)would hit an assertion errorwhen the compiler tried to infer the type of the literal 2. The compiler
tries to find the type of the receiver of the function, in this case
1, but it lacked the ability to do so when using partial functions. Inthose cases, the compiler would try to look at the type of the
~token, which is not a valid value literal, and as such it would fail.
Fixes #3531