Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove options package #3844

Merged
merged 2 commits into from
Sep 12, 2021
Merged

Remove options package #3844

merged 2 commits into from
Sep 12, 2021

Conversation

rhagenson
Copy link
Member

Removes the options package which was deprecated in ae7d070a0d2cb3fc24c9c796 on December 11, 2018.

@rhagenson rhagenson added the do not merge This PR should not be merged at this time label Sep 12, 2021
@rhagenson
Copy link
Member Author

Marked as do not merge while I wait to understand the proper way to add the release notes to ponylang-main picks up said notes.

@SeanTAllen SeanTAllen changed the title RM options package Remove options package Sep 12, 2021
@SeanTAllen SeanTAllen added the changelog - changed Automatically add "Changed" CHANGELOG entry on merge label Sep 12, 2021
@ponylang-main
Copy link
Contributor

Hi @rhagenson,

The changelog - changed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do.

Release notes are added by creating a uniquely named file in the .release-notes directory. We suggest you call the file 3844.md to match the number of this pull request.

The basic format of the release notes (using markdown) should be:

## Title

End user description of changes, why it's important,
problems it solves etc.

If a breaking change, make sure to include 1 or more
examples what code would look like prior to this change
and how to update it to work after this change.

Thanks.

@rhagenson rhagenson removed the do not merge This PR should not be merged at this time label Sep 12, 2021
@rhagenson
Copy link
Member Author

This ended up being pretty straightforward. We did not have any remaining uses of options in stdlib or examples. I added a before and after rewrite of the example program that was in options documentation using cli for release notes, but I would be surprised to learn anyone has not made the switch to cli yet.

@SeanTAllen SeanTAllen merged commit 367c2d9 into main Sep 12, 2021
@SeanTAllen SeanTAllen deleted the rm-options-pkg branch September 12, 2021 03:20
@SeanTAllen
Copy link
Member

Thanks @rhagenson

github-actions bot pushed a commit that referenced this pull request Sep 12, 2021
github-actions bot pushed a commit that referenced this pull request Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - changed Automatically add "Changed" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants