Fix underlying time source for Time.nanos() on macOS #3921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joe already applied this fix to cpu.c on 197b952, but we missed the call to mach_absolute_time on time.pony
ergl
added
the
changelog - fixed
|
When this is merged, we should add a note to LWIP so that others running on Apple Silicon have a chance to upgrade, since this affects the behaviour of timers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were using
mach_absolute_timeon macOS to get the number of ticks since boot, with the assumption that ticks increment at nanosecond intervals. However, as noted by Apple, this assumption is flawed on Apple Silicon, and will also affect any binaries that were built on Intel, as the Rosetta 2 translator will not apply any time conversion.The recommended replacement to
mach_absolute_timeis to useclock_gettime_nsec_npwith a clock of typeCLOCK_UPTIME_RAW.Joe already applied this fix to
cpu.con 197b952, but we missed the call tomach_absolute_timeontime.pony