Fix compiler crash related to using tuples as a generic constraint #4005
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tuple types aren't legal constraints on generics in Pony and we have a check in
the syntax pass to detect and report that error. However, it was previously
possible to sneak a tuple type as a generic constraint past the syntax check by
smuggling it in a type alias.
Type aliases aren't flattened into their various components until the flatten
pass which follows the syntax pass. This means that the following code would
cause a compiler assertion:
This commit adds an additional check in the flatten pass to report an error on
smuggled tuple types as generic constraints.
Fixes #3655