Some small cleanups #4331
Closed
Some small cleanups #4331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this matches lists and hashmaps
Although def->permissions is only NULL on non-actor behaviors and type alias functions, And thus they should never get here, we should assert before we null deref
Instead cast at each use with the new type.
with the other HASHMAP functions by taking a name_t, not a general hashmap_t
ponylang-main
added
the
discuss during sync
|
Please break these into logical commits with a PR for each. If these ever come up in history as "why was this changed", bunching them altogether will be detrimental to understanding. Additionally, it's not guaranteed that we will want to accept each of these changes. |
|
Some of the changes I'm good with, others I'm not. |
|
Ok, I'll make a PR for each commit, they are all mutually separable. |
This was referenced Mar 20, 2023
Merged
|
Thanks @Dante-Broggi. I'm closing this PR. |
ponylang-main
removed
the
discuss during sync
This was referenced Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I should actually PR the cleanup and improvements I find.