Ensure all build files go into correct output dir when use flags are enabled
#4361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ponylang-main
added
the
discuss during sync
|
I don't feel qualified to comment on CMake improvements, so I'm requesting review from @chalcolith. |
chalcolith
approved these changes
Jul 7, 2023
|
@dipinhora can you rebase this against main? |
…e enabled Prior to this commit, build with `use` flags enabled would have some build files saved to the wrong directory (i.e. `build/debug` instead of `build/debug-runtimestats`). This commit updates the various `CMakeLists.txt` files to ensure all copy commands use the directories with `PONY_OUTPUT_SUFFIX` appended so that all build files are appropriately in the relevant output directory for the `use` flag enabled build.
done |
ponylang-main
removed
the
discuss during sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, build with
useflags enabled would have some build files saved to the wrong directory (i.e.build/debuginstead ofbuild/debug-runtimestats).This commit updates the various
CMakeLists.txtfiles to ensure all copy commands use the directories withPONY_OUTPUT_SUFFIXappended so that all build files are appropriately in the relevant output directory for theuseflag enabled build.