Use distinct directory when multiple use= flags are enabled
#4365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the output directory used when multiple `use=` flags were enabled would be the directory for the last `use=` flag enabled in source code order. This commit changes it so that the output directory uses a distinct name that concats all the `use=` flags enabled together (i.e. the output directory will be `debug-valgrind-runtimestats` instead of `debug-runtimestats`).
ponylang-main
added
the
discuss during sync
|
@chalcolith can you give this a review please? |
chalcolith
approved these changes
Jul 16, 2023
ponylang-main
removed
the
discuss during sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the output directory used when multiple
use=flags were enabled would be the directory for the lastuse=flag enabled in source code order.This commit changes it so that the output directory uses a distinct name that concats all the
use=flags enabled together (i.e. the output directory will bedebug-valgrind-runtimestatsinstead ofdebug-runtimestats).