Specialize heap small and large chunk implementations #4366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the heap `chunk_t` was generic for both small and large chunks taking up more space than required for either one. This commit specializes the small and large chunk structures by using pointer tagging on the `chunk->m` field to keep track of the chunk type and large chunk slot/shallow/finaliser and the small chunk sizeclass. This should in theory improve performance as now the `large_chunk_t` is 32 bytes and `small_chunk_t` is 36 bytes on 64 bit platforms (while `chunk_t` was previously 44 bytes. There are no logic changes other than whatever was required to support the specialization.
ponylang-main
added
the
discuss during sync
ponylang-main
removed
the
discuss during sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the heap
chunk_twas generic for both small and large chunks taking up more space than required for either one.This commit specializes the small and large chunk structures by using pointer tagging on the
chunk->mfield to keep track of the chunk type and large chunk slot/shallow/finaliser and the small chunk sizeclass. This should in theory improve performance as now thelarge_chunk_tis 32 bytes andsmall_chunk_tis 36 bytes on 64 bit platforms (whilechunk_twas previously 44 bytes.There are no logic changes other than whatever was required to support the specialization.