Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Add -ld_classic linker option to mac builds #4465

Closed
wants to merge 3 commits into from

Conversation

d-led
Copy link

@d-led d-led commented Oct 11, 2023

Problem

linking both Pony programs and ponyc fail with ld: Missing -platform_version option

Discussion

see #4454

ld versions

@d-led:

ld -v
@(#)PROGRAM:ld  PROJECT:dyld-1015.7
BUILD 18:48:43 Aug 22 2023
configured to support archs: armv6 armv7 armv7s arm64 arm64e arm64_32 i386 x86_64 x86_64h armv6m armv7k armv7m armv7em
will use ld-classic for: armv6 armv7 armv7s arm64_32 i386 armv6m armv7k armv7m armv7em
LTO support using: LLVM version 15.0.0 (static support for 29, runtime is 29)
TAPI support using: Apple TAPI version 15.0.0 (tapi-1500.0.12.3)

@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Oct 11, 2023
@SeanTAllen
Copy link
Member

You can remove the cmakelist change

@SeanTAllen
Copy link
Member

Can you convert this to a draft PR so that merge isn't an option for now?

@d-led d-led marked this pull request as draft October 11, 2023 14:15
@d-led
Copy link
Author

d-led commented Oct 11, 2023

reverted the cmake change & converted to draft. PS I chedked "Allow edits by maintainers", in case you want to commit directly to the branch

@SeanTAllen
Copy link
Member

@d-led awesome. thanks. if this works, do you want to write the release notes and "bring this all the way home" or would you prefer for me to step in for "the extras" like release notes?

@SeanTAllen
Copy link
Member

@d-led which version of xcode introduced this problem?

@SeanTAllen
Copy link
Member

This doesn't work with the older xcode. Sadly.

@d-led
Copy link
Author

d-led commented Oct 11, 2023

This doesn't work with the older xcode. Sadly.

as expected. Version check or an optional flag in both cmake and ponyc?

@d-led
Copy link
Author

d-led commented Oct 11, 2023

@d-led which version of xcode introduced this problem?

I haven't yet followed up and thus don't know ☹️ . I would suggest decoupling the work-around from the xcode versions: who knows, maybe they'll invert the default...

@SeanTAllen
Copy link
Member

the problem with version check is it would have to be done at the time linking is done. it doesnt do any good for something that is distributing binaries like us, homebrew etc if it isn't done at the time each pony program is being linked.

@d-led
Copy link
Author

d-led commented Oct 11, 2023

it seems, xcode 15 is the culprit (unverified)

@SeanTAllen SeanTAllen closed this Oct 17, 2023
@ponylang-main ponylang-main removed the discuss during sync Should be discussed during an upcoming sync label Oct 17, 2023
@SeanTAllen
Copy link
Member

Closed "in favor of" #4466 if we can get it validated.

@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss during sync Should be discussed during an upcoming sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants