-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple Enum support (#502) #585
Open
luckydonald
wants to merge
43
commits into
ponyorm:orm
Choose a base branch
from
luckydonald-forks:enum_support
base: orm
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as it is bound to `self.converter`. Enum effort.
…ed 64-bit/8-byte numbers, for those at least try signed variant which effectively would be 63-bit.
…`attr` was taking that position.
when inserting integer Enums.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request for tracking the work for #502.
The way it works is actually quite simple:
In python, enums are a subtype of both
Enum
, and a base type (int
,str
,bool
, etc.)In
other wordscode:This means we can simply use those values which is backing the enums as database values.
All this PR does is checking the enum type for what the underlying type would be processed as (
self._get_real_converter(py_type, attr)
), and store that converter internally (self.converter
).Now all the fancy converter methods (
py2sql
,sql2py
,val2dbval
, …) will be forwarded to that chosen converter.That's it.
Bonus feature: It chooses the size of the integer or string colums correctly if you don't provide those.