This repository has been archived by the owner on Oct 8, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
Deploy server as an action and configure dependencies via newer pipenv #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5096710.
This reverts commit 8429334.
This reverts commit 96c6bb5.
This reverts commit 998d75b.
This reverts commit 36e2471.
This reverts commit c4fb6ec.
This reverts commit 7967fb4.
This reverts commit 6c3c1ff.
This reverts commit dc3b9ea.
This reverts commit 2bd9db9.
This reverts commit b7f7482.
This reverts commit a98e442.
This reverts commit 2714233.
This reverts commit 6183a6a.
kantoniak
suggested changes
Mar 24, 2020
Robert-Mic
reviewed
Mar 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why .sample was deleted, otherwise it looks good :)
kantoniak
suggested changes
Mar 26, 2020
kantoniak
approved these changes
Mar 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll approve, but I think deploying form multiple branches is a big no-no.
can introduce testing deploy server as the separate action, then will change this action to be launched only on master branch |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's configured to refresh the data on server every time the push changes the django-server folder at any branch (so clean the server repo on heroku and push there all the files from server folder to setup server based on Pipfile)