This repository has been archived by the owner on Dec 22, 2020. It is now read-only.
Save Japanese word bug fixed #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found similar issue in Chinese, the pinyin of the word included with the word itself, just like the romaji is included in Japanese too. I guess there should be a more general solution for this, instead of
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, if I'm trying to save the entry 「汗」 with BetterDictionary, i got 「汗【あせ】」. So when I click the saved entry, I actually load 「汗【あせ】」 into the search box, which definitely results in 「No entries found.」. Therefore I added a method to the load process to correctly save the Japanese word entry as 「汗」.