Chore: Use Just instead of Make #323
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drakulix
reviewed
Feb 26, 2024
Drakulix
reviewed
Mar 4, 2024
dengelt
reviewed
Jul 14, 2024
| export SHARE_DIR := sharedir | ||
| export BIN_DIR := base-dir / 'bin' | ||
| export LIB_DIR := libdir | ||
|
|
There was a problem hiding this comment.
Suggestion: Add a line like cargo-target-dir := env('CARGO_TARGET_DIR', 'target') here to read the CARGO_TARGET_DIR environment variable.
dengelt
reviewed
Jul 14, 2024
| export BIN_DIR := base-dir / 'bin' | ||
| export LIB_DIR := libdir | ||
|
|
||
| bin-src := 'target' / 'release' / name |
There was a problem hiding this comment.
Suggestion: Change this line to bin-src := cargo-target-dir / 'release' / name to use the previously read environment variable instead of hardcoding the target directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the build automation system over to Just instead of Make.
Todo (but I may not have the time to do them):