-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cosmic_atspi_v1
protocol
#759
Conversation
It's just a hacky prototype at the moment, but this now partly works with https://github.com/ids1024/at-spi2-core/tree/atspi-ei. Orca keybindings now work, but the keys are also sent to applications. We need something like X11's I think that's pretty much the only other thing we need for parity with We'll also need a secure mechanism to start the screen reader, and only give it access to this. |
d01b986
to
72d1664
Compare
5d1c4a9
to
d6e3b8b
Compare
I've fixed an I think we can merge this now, with the understanding that it will be improved later, and won't cause issues when the protocol isn't in use. |
src/input/mod.rs
Outdated
.active_virtual_mods | ||
.insert(event.key_code()); | ||
|
||
tracing::error!( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we downgrade this to at least info
(probably debug
)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right, that's a debugging line I added at some point that I didn't mean to commit. (Downgrading to debug
would be appropriate).
src/input/mod.rs
Outdated
@@ -1649,6 +1707,16 @@ impl State { | |||
return FilterResult::Intercept(None); | |||
} | |||
|
|||
// TODO modifiers queue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this todo problematic? Can this currently interact weirdly with modifier only keybindings? (mostly for future reference to understand what needs to be done here.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that was just a comment to remind myself to look into whether this interacts problematically with that at some point. Not for any known issue.
I'll just remove that comment, but more testing could definitely be done in general.
Used to provide a backend for `AtspiDevice` in `at-spi2-core`, so Orca keybindings can work.
This works with the
receive
example ofreis
usingLIBEI_SOCKET=/tmp/atspi-ei-kb.socket
. I've also worked on changes to at-spi2-core, so I'll now be able to try testing it...If a version of this is ultimately used, it will need a secure way to pass the socket to accessibility tools. Putting it in
/tmp
is a placeholder.