Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Menu] Use corner radius from theme #935

Merged
merged 1 commit into from
Oct 21, 2024
Merged

[Menu] Use corner radius from theme #935

merged 1 commit into from
Oct 21, 2024

Conversation

git-f0x
Copy link
Contributor

@git-f0x git-f0x commented Oct 21, 2024

Just makes the context menu use @radius_s for the corner radius, to match the highlight for items inside.
I also tried to make the stack header do the same, but it didn't seem to pick up roundness changes.

@git-f0x git-f0x mentioned this pull request Oct 21, 2024
Merged
Drakulix
Drakulix approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@Drakulix Drakulix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Drakulix Drakulix merged commit 50d6dc3 into pop-os:master Oct 21, 2024
1 check passed
@Drakulix
Copy link
Member

What exactly did you try to change the stack? Would like to take a look at that.

@git-f0x
Copy link
Contributor Author

git-f0x commented Oct 21, 2024 •
edited
Loading

I changed the 8.0 here to radius_s (theme::active().cosmic().radius_s()[0]).
Possibly that way of getting info from the theme doesn't work properly in comp (same as getting the spacing variables).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Drakulix Drakulix Drakulix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@git-f0x @Drakulix