Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timezone #57

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

francesco-gaglione
Copy link

close #40

@@ -94,14 +96,25 @@ async fn main() {

path.to_string_lossy().to_string()
} else {
uri.path().to_string()
let re = Regex::new(r"screenshot-(\d{4}-\d{2}-\d{2}-\d{2}-\d{2}-\d{2})").unwrap();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not correct to try and replace this path with a regex, instead the path should be adjusted where it is originally created.

Copy link
Member

@jackpot51 jackpot51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@francesco-gaglione
Copy link
Author

francesco-gaglione commented Sep 17, 2024

Please fix this in the correct project, https://github.com/pop-os/xdg-desktop-portal-cosmic/

I'm trying to fix here, but there are no build, test and install instructions. How can I test this fixes?

@jackpot51 I tried to make and make install in xdg-desktop-portal-cosmic and than run again the cosmic-screenshot but my code changes in xdg-desktop-portal-cosmic were not there. It seem not installing xdg-desktop-portal-cosmic. There are some build/install/test instruction?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong timestamps for the screenshots' file names
2 participants