-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix timezone #57
base: master
Are you sure you want to change the base?
Fix timezone #57
Conversation
@@ -94,14 +96,25 @@ async fn main() { | |||
|
|||
path.to_string_lossy().to_string() | |||
} else { | |||
uri.path().to_string() | |||
let re = Regex::new(r"screenshot-(\d{4}-\d{2}-\d{2}-\d{2}-\d{2}-\d{2})").unwrap(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not correct to try and replace this path with a regex, instead the path should be adjusted where it is originally created.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix this in the correct project, https://github.com/pop-os/xdg-desktop-portal-cosmic/
I'm trying to fix here, but there are no build, test and install instructions. How can I test this fixes? @jackpot51 I tried to make and make install in xdg-desktop-portal-cosmic and than run again the cosmic-screenshot but my code changes in xdg-desktop-portal-cosmic were not there. It seem not installing xdg-desktop-portal-cosmic. There are some build/install/test instruction? |
close #40