feat: Profile option to open new terms in last focused term's CWD [rebased 2024-10-06] #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuamegnauth54
force-pushed
the
feat-new-tab-open-in-cwd
branch
2 times, most recently
from
b62121c
to
c261fb2
Compare
|
I think this should be under profiles. |
|
Do you mean as a per profile setting? |
|
Alright, I moved the setting over to Profiles. |
joshuamegnauth54
force-pushed
the
feat-new-tab-open-in-cwd
branch
2 times, most recently
from
7a8f93a
to
e5bcfac
Compare
joshuamegnauth54
force-pushed
the
feat-new-tab-open-in-cwd
branch
from
e5bcfac
to
3e33977
Compare
joshuamegnauth54
changed the title
joshuamegnauth54
force-pushed
the
feat-new-tab-open-in-cwd
branch
from
3e33977
to
01e605b
Compare
joshuamegnauth54
force-pushed
the
feat-new-tab-open-in-cwd
branch
from
01e605b
to
3ea6722
Compare
joshuamegnauth54
changed the title
joshuamegnauth54
force-pushed
the
feat-new-tab-open-in-cwd
branch
from
3ea6722
to
d48fdc0
Compare
joshuamegnauth54
force-pushed
the
feat-new-tab-open-in-cwd
branch
from
d48fdc0
to
369a497
Compare
Closes: pop-os#251 This patch implements an optional (but enabled by default) feature for opening new terminals using the focused terminal's working directory. The code to retrieve the CWD is largely based on Alacritty's implementation of the same feature. I added Rustix as a new direct dependency for the working directory logic. Both libc and Rustix are transitive dependencies of COSMIC Term. I opted for Rustix over libc to avoid an `unsafe` block as well as for its stronger type guarantees. References: * https://github.com/alacritty/alacritty/blob/6bd1674bd80e73df0d41e4342ad4e34bb7d04f84/alacritty/src/daemon.rs#L85-L108
The option is enabled by default on Unix but settable per profile. Windows is currently unsupported and defaults to the old behavior.
joshuamegnauth54
force-pushed
the
feat-new-tab-open-in-cwd
branch
from
369a497
to
6082f3b
Compare
joshuamegnauth54
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #251
This patch implements an optional (but enabled by default) feature for opening new terminals using the focused terminal's working directory. The code to retrieve the CWD is largely based on Alacritty's implementation of the same feature.
It works but I have one small change to work on later.
Todo: