Small optimizations #302
Merged
Small optimizations #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grovesNL
reviewed
Aug 31, 2024
| @@ -21,6 +21,7 @@ rangemap = "1.4.0" | |||
| rustc-hash = { version = "1.1.0", default-features = false } | |||
| rustybuzz = { version = "0.14", default-features = false, features = ["libm"] } | |||
| self_cell = "1.0.1" | |||
| smol_str = { version = "0.2.2", default-features = false } | |||
There was a problem hiding this comment.
For what it's worth, smol_str doesn't seem to be recommended anymore (see the comment by the original author in https://www.reddit.com/r/rust/comments/117ksvr/comment/j9eh35d/)
There's also a comparison of small string crates at https://github.com/rosetta-rs/string-rosetta-rs?tab=readme-ov-file (smol_str was removed from the table in favor of ecow)
There was a problem hiding this comment.
I'm not necessarily against it but consider:
smol_strhas much more adoption, so it's less likely to increase the dependency footprint of users (e.g.bevyusessmol_str).smol_stroffers 23 inline bytes vs only 15 inecow, and the use-case here really doesn't want to allocate.
jackpot51
approved these changes
Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SmolStrinstead ofStringinFamilyOwned. Families are almost always <= 23 bytes. Note thatSmolStrisno-stdwhen default features are off.AttrsList::spans_iterto avoid an unnecessary allocation inBuffer::append.