-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(scalable): Add night light icon #104
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: DarkJoker360 <simoespo159@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took the icon from moon weather icon rather than having the old one to match new redefined icons design, such as volume icon etc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The height does match the other icons, and it's showing up as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently this just adds the icon to the theme folder, however if added this way the icon will be removed on the next icon theme update due to purging of this folder during renders.
Please add the icon to the master template file (src/scalable/source-symbolic.svg) in the status layer following the template provided by the other icons in the file. This will ensure that the icon does not get overwritten by future theme updates.
Alright. |
Before releasing, |
@DarkJoker360 I'm not sure if you're still interested in this PR, but I've updated a lot of documentation which should aid you in getting your PR updated with the correct modifications. The relevant docs are in: |
This change adds a themed icon for night light status icon, similiar to what we used to have in 20.04 and older releases.
Before (current default icon): https://imgur.com/a/xiQHfxz
After (new icon): https://imgur.com/a/DZ1AXoS
I am adding here the icon 20.04 icon as reference: https://imgur.com/a/fPUS4qZ