Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scalable): Add night light icon #104

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DarkJoker360
Copy link

This change adds a themed icon for night light status icon, similiar to what we used to have in 20.04 and older releases.

Before (current default icon): https://imgur.com/a/xiQHfxz
After (new icon): https://imgur.com/a/DZ1AXoS

I am adding here the icon 20.04 icon as reference: https://imgur.com/a/fPUS4qZ

Signed-off-by: DarkJoker360 <simoespo159@gmail.com>
@jacobgkau jacobgkau requested a review from a team March 2, 2022 18:43
Copy link
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current 20.04:
Screenshot from 2022-03-02 14-47-07

Current 21.10:
Screenshot from 2022-03-02 14-46-28

New 21.10:
Screenshot from 2022-03-02 14-46-00

The new icon doesn't quite match the old icon. To me, it looks like the old icon used the crescent shape from the center of the stock GNOME icon. Where does the new shape come from?

@DarkJoker360
Copy link
Author

I took the icon from moon weather icon rather than having the old one to match new redefined icons design, such as volume icon etc

Copy link
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The height does match the other icons, and it's showing up as expected.

@jacobgkau jacobgkau requested a review from a team March 2, 2022 22:00
@jackpot51 jackpot51 requested a review from isantop March 2, 2022 22:07
Copy link
Contributor

@isantop isantop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently this just adds the icon to the theme folder, however if added this way the icon will be removed on the next icon theme update due to purging of this folder during renders.

Please add the icon to the master template file (src/scalable/source-symbolic.svg) in the status layer following the template provided by the other icons in the file. This will ensure that the icon does not get overwritten by future theme updates.

@DarkJoker360
Copy link
Author

Alright.
I have a doubt in how I should edit the file (src/scalable/source-symbolic.svg), I tried src/scalable/ scripts and master-render.py which I believe are for different purpose. Any hints on how to do so? Thank you

@isantop
Copy link
Contributor

isantop commented May 9, 2022

master-render.py is the overall rendering script. It will call each rendering script for each different type of asset in turn. You can use it to render the icon after you're finished to test it out.

Before releasing, master-render.py -c will do a complete re-render, which is helpful to make sure the icon will not get overwritten.

@isantop
Copy link
Contributor

isantop commented Aug 8, 2022

@DarkJoker360 I'm not sure if you're still interested in this PR, but I've updated a lot of documentation which should aid you in getting your PR updated with the correct modifications. The relevant docs are in:

README.md@c815841

src/scalable/README.md@c815841

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants