Skip to content

Commit

Permalink
binder: use standard functions to allocate fds
Browse files Browse the repository at this point in the history
Binder uses internal fs interfaces to allocate and install fds:

__alloc_fd
__fd_install
__close_fd
get_files_struct
put_files_struct

These were used to support the passing of fds between processes
as part of a transaction. The actual allocation and installation
of the fds in the target process was handled by the sending
process so the standard functions, alloc_fd() and fd_install()
which assume task==current couldn't be used.

This patch refactors this mechanism so that the fds are
allocated and installed by the target process allowing the
standard functions to be used.

The sender now creates a list of fd fixups that contains the
struct *file and the address to fixup with the new fd once
it is allocated. This list is processed by the target process
when the transaction is dequeued.

A new error case is introduced by this change. If an async
transaction with file descriptors cannot allocate new
fds in the target (probably due to out of file descriptors),
the transaction is discarded with a log message. In the old
implementation this would have been detected in the sender
context and failed prior to sending.

Signed-off-by: Todd Kjos <tkjos@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Todd Kjos authored and gregkh committed Sep 14, 2018
1 parent 44b7396 commit 44d8047
Show file tree
Hide file tree
Showing 3 changed files with 260 additions and 165 deletions.
2 changes: 1 addition & 1 deletion drivers/android/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ if ANDROID

config ANDROID_BINDER_IPC
bool "Android Binder IPC Driver"
depends on MMU
depends on MMU && !CPU_CACHE_VIVT
default n
---help---
Binder is used in Android for both communication between processes,
Expand Down
Loading

0 comments on commit 44d8047

Please sign in to comment.