Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fbdev: Disable sysfb device registration when removing conflicting FBs" #178

Merged
merged 2 commits into from
Sep 22, 2022
Merged

Revert "fbdev: Disable sysfb device registration when removing conflicting FBs" #178

merged 2 commits into from
Sep 22, 2022

Conversation

jackpot51
Copy link
Member

@jackpot51 jackpot51 commented Sep 19, 2022 •
edited
Loading

This is an alternative to #177 and may fix plymouth on NVIDIA GPUs. Marked as draft because #177 is preferred if it works.

@jackpot51 jackpot51 requested review from a team September 19, 2022 17:54
@jackpot51 jackpot51 self-assigned this Sep 19, 2022
@jackpot51 jackpot51 marked this pull request as draft September 19, 2022 19:17
@jackpot51 jackpot51 closed this Sep 19, 2022
@jackpot51 jackpot51 deleted the revert-sysfb_jammy branch September 19, 2022 22:14
@leviport leviport restored the revert-sysfb_jammy branch September 20, 2022 20:44
@leviport leviport reopened this Sep 20, 2022
@leviport
Copy link
Member

Reopening for more testing

@leviport
Copy link
Member

With this patch, mega-r2 reaches the non-graphical decrypt prompt if quiet splash are removed from boot params. With quiet splash, boot once again hangs at the BIOS splash screen, and blindly typing the password gets me to the login screen.

@leviport
Copy link
Member

I tested some other kernels as well, and it is good in 5.18.12, but breaks in 5.18.13.

@jackpot51 jackpot51 marked this pull request as ready for review September 21, 2022 20:11
@jackpot51
Copy link
Member Author

I reverted another related commit, please test once it builds

@leviport
Copy link
Member

This now fixes mega-r2 as well as mira-r2 which had the blank screen bug before this update.

I'm going to test a few more machines, but this should be ready to go soon 🚀

@leviport
Copy link
Member

leviport commented Sep 21, 2022 •
edited
Loading

  • mega-r2 w/2080
  • mira-r2 w/1070
  • oryp6, all graphics modes
  • Dev One
  • kudu6
  • mira-r2 w/5500XT
  • thelio-r2 (5650g integrated)
  • thelio-mira-b3 (12th gen integrated)
  • mega-r2 w/W6800 Pro

@jackpot51 jackpot51 merged commit 28340d4 into master Sep 22, 2022
@jackpot51 jackpot51 deleted the revert-sysfb_jammy branch September 22, 2022 11:31
@jackpot51 jackpot51 mentioned this pull request Sep 22, 2022
Closed
@leviport leviport mentioned this pull request Sep 22, 2022
Closed
@leviport leviport mentioned this pull request Oct 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@13r0ck 13r0ck 13r0ck approved these changes

@leviport leviport leviport approved these changes

Assignees

@jackpot51 jackpot51

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackpot51 @leviport @13r0ck