TGL-H GPIOs Workaround #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Crawford <tcrawford@system76.com>
The software mapping for GPIO, which initially comes from Microsoft, is subject to change by respective Windows and firmware developers. Due to the above the driver had been written and published way ahead of the schedule, and thus the numbering schema used in it is outdated. Fix the numbering schema in accordance with the real products on market. Fixes: 653d964 ("pinctrl: tigerlake: Add support for Tiger Lake-H") Reported-and-tested-by: Kai-Heng Feng <kai.heng.feng@canonical.com> Reported-by: Riccardo Mori <patacca@autistici.org> Reported-and-tested-by: Lovesh <lovesh.bond@gmail.com> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=213463 BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=213579 BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=213857 Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
jackpot51
force-pushed
the
tglh-gpios_nobuild
branch
from
6d56df8 to
5c02c56
Compare
jackpot51
force-pushed
the
tglh-gpios_nobuild
branch
from
5c02c56 to
930e87c
Compare
Member
Author
|
I pushed this as oryp8_impish so it only builds on 21.10 |
Member
Author
|
I pushed this as oryp8_focal and oryp8_hirsute. When approved, I will make master the same commit to avoid rebuilts |
crawfxrd
approved these changes
Sep 15, 2021
jacobgkau
approved these changes
Sep 16, 2021
Member
jacobgkau
left a comment
jacobgkau
left a comment
There was a problem hiding this comment.
This gets audio working as expected on oryp8, and allows the touchpad to work on gaze16 with both currently-released firmware (93c2809) and firmware built from master with the system76 branch of coreboot.
This will need to make its way into an iso before we release the next firmware update for gaze16.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #63 and #70, but provides a fallback for the gaze16 when it has older firmware with an older GPIO table. Not building for staging to avoid build server contention