Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use patched pbr to fix cli #202

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Use patched pbr to fix cli #202

merged 1 commit into from
Aug 8, 2023

Conversation

ids1024
Copy link
Member

@ids1024 ids1024 commented Aug 7, 2023

Fixes #201.

This should be changed when a8m/pb#120 is merged and released.

@ids1024
Use patched pbr to fix cli
9b7a043 
Fixes #201.

This should be changed when a8m/pb#120 is merged
and released.
@ids1024 ids1024 requested review from a team August 7, 2023 21:58
@jacobgkau jacobgkau self-assigned this Aug 8, 2023
jacobgkau
jacobgkau approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the progress bar when using the CLI and makes the CLI exit after flashing as expected.

The GUI still works as expected.

@jackpot51 jackpot51 merged commit c5bf861 into master Aug 8, 2023
4 checks passed
@jackpot51 jackpot51 deleted the pbr-fix branch August 8, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackpot51 jackpot51 jackpot51 approved these changes

@jacobgkau jacobgkau jacobgkau approved these changes

Assignees

@jacobgkau jacobgkau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

popsicle CLI hangs, but finishes flashing USB
3 participants
@ids1024 @jacobgkau @jackpot51