Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update loopdev to loopdev-erikh #210

Merged
merged 1 commit into from
Jan 9, 2024
Merged

fix: update loopdev to loopdev-erikh #210

merged 1 commit into from
Jan 9, 2024

Conversation

mmstick
Copy link
Member

@mmstick mmstick commented Jan 5, 2024 •
edited
Loading

This will bump bindgen to version 63.0, which should fix #208, where bindgen has build errors on newer versions of Clang. Loopdev has been abandoned (rustsec/advisory-db#1821), but loopdev-erikh is maintained.

@mmstick mmstick requested review from a team January 5, 2024 16:50
@mmstick mmstick mentioned this pull request Jan 5, 2024
Closed
@jacobgkau jacobgkau self-assigned this Jan 8, 2024
@jacobgkau jacobgkau mentioned this pull request Jan 8, 2024
Open
jacobgkau
jacobgkau approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Popsicle GUI and CLI features are still working as expected after this crate switch & cargo update.

@jackpot51 jackpot51 merged commit 3382c77 into master Jan 9, 2024
9 checks passed
@jackpot51 jackpot51 deleted the loopdev branch January 9, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackpot51 jackpot51 jackpot51 approved these changes

@jacobgkau jacobgkau jacobgkau approved these changes

Assignees

@jacobgkau jacobgkau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v1.3.2 and latest commit from master branch no longer build on Arch Linux
3 participants
@mmstick @jacobgkau @jackpot51