Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tiling): Delay focus check in case window is not focused yet #1314

Merged
merged 1 commit into from
Jan 12, 2022
Merged

fix(tiling): Delay focus check in case window is not focused yet #1314

merged 1 commit into from
Jan 12, 2022

Conversation

mmstick
Copy link
Member

@mmstick mmstick commented Jan 12, 2022

Fixes #1312

@mmstick mmstick requested review from a team January 12, 2022 14:05
leviport
leviport previously approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@leviport leviport left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could reproduce #1312 on my gaze10 before adding the fix. Confirmed that this fixes it!

Edit: noticed this is going into master, so this needs regression testing before approval.

@leviport leviport self-requested a review January 12, 2022 17:45
@leviport leviport dismissed their stale review January 12, 2022 17:47

need regression testing

@leviport leviport requested review from a team and removed request for leviport January 12, 2022 17:47
jacobgkau
jacobgkau approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also confirmed this fixes #1312 on 21.10 and 20.04.

Regression testing passed:
shell-pr1314-impish.txt
shell-pr1314-focal.txt

@mmstick mmstick merged commit b3b2e35 into master Jan 12, 2022
@mmstick mmstick deleted the intellij branch January 12, 2022 19:18
@StarpTech
Copy link

Hi, thank you for the fix. When will it be released?

@jacobgkau
Copy link
Member

Hi, thank you for the fix. When will it be released?

It will be released once this package management PR is merged and the build server has a chance to make the release: pop-os/repo-release#17

@StarpTech
Copy link

@jacobgkau thanks!

@jacobgkau jacobgkau mentioned this pull request Jan 12, 2022
Closed
@mmstick mmstick mentioned this pull request Jan 13, 2022
Closed
@Gabrola Gabrola mentioned this pull request Feb 4, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackpot51 jackpot51 jackpot51 approved these changes

@jacobgkau jacobgkau jacobgkau approved these changes

@leviport leviport leviport left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@mmstick @StarpTech @jacobgkau @jackpot51 @leviport