Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase on Upstream Version #365

Merged
merged 330 commits into from
Jul 8, 2022
Merged

Rebase on Upstream Version #365

merged 330 commits into from
Jul 8, 2022

Conversation

isantop
Copy link

@isantop isantop commented Jun 29, 2022 •
edited
Loading

Updates the Pop_Shop base to the latest upstream version.

New changes in this rebase:

  • AppCenter now uses an app menu.
  • Software Sources button has moved to the App Menu.
  • Software Sources can now be opened with a keyboard shortcut (Ctrl+S)
  • Apt Cache and Flatpak Metadata can now be refreshed within Pop_Shop (Menu button or Ctrl+R)
  • Touchpad users can swipe to go back from an app listing
  • General performance improvements and bugfixes

IhorHordiichuk and others added 30 commits January 7, 2022 20:57
@IhorHordiichuk
Translated using Weblate (Ukrainian)
0bb1d91 
Currently translated at 100.0% (231 of 231 strings)

Translation: AppCenter/AppCenter
Translate-URL: https://l10n.elementary.io/projects/appcenter/appcenter/uk/
@frachmadin
Translated using Weblate (Indonesian)
a1bc1b5 
Currently translated at 100.0% (231 of 231 strings)

Translation: AppCenter/AppCenter
Translate-URL: https://l10n.elementary.io/projects/appcenter/appcenter/id/
@gusti-alfarisy
Translated using Weblate (Indonesian)
034eaa4 
Currently translated at 100.0% (231 of 231 strings)

Translation: AppCenter/AppCenter
Translate-URL: https://l10n.elementary.io/projects/appcenter/appcenter/id/
@IhorHordiichuk
Translated using Weblate (Ukrainian)
5c56c59 
Currently translated at 100.0% (146 of 146 strings)

Translation: AppCenter/AppCenter (Extra)
Translate-URL: https://l10n.elementary.io/projects/appcenter/extra/uk/
@frachmadin
Translated using Weblate (Indonesian)
caf5ac4 
Currently translated at 100.0% (146 of 146 strings)

Translation: AppCenter/AppCenter (Extra)
Translate-URL: https://l10n.elementary.io/projects/appcenter/extra/id/
@yarons
Translated using Weblate (Hebrew)
400309a 
Currently translated at 100.0% (146 of 146 strings)

Translation: AppCenter/AppCenter (Extra)
Translate-URL: https://l10n.elementary.io/projects/appcenter/extra/he/
Translated using Weblate (Catalan)
a04ef19 
Currently translated at 100.0% (231 of 231 strings)

Translation: AppCenter/AppCenter
Translate-URL: https://l10n.elementary.io/projects/appcenter/appcenter/ca/
Translated using Weblate (Catalan)
1c9d49d 
Currently translated at 100.0% (146 of 146 strings)

Translation: AppCenter/AppCenter (Extra)
Translate-URL: https://l10n.elementary.io/projects/appcenter/extra/ca/
@DartDeaDia
Translated using Weblate (Russian)
cd54e6a 
Currently translated at 100.0% (231 of 231 strings)

Translation: AppCenter/AppCenter
Translate-URL: https://l10n.elementary.io/projects/appcenter/appcenter/ru/
@DartDeaDia
Translated using Weblate (Russian)
4566cbf 
Currently translated at 98.6% (144 of 146 strings)

Translation: AppCenter/AppCenter (Extra)
Translate-URL: https://l10n.elementary.io/projects/appcenter/extra/ru/
@martin-stastny
Translated using Weblate (Czech)
2228197 
Currently translated at 79.6% (184 of 231 strings)

Translation: AppCenter/AppCenter
Translate-URL: https://l10n.elementary.io/projects/appcenter/appcenter/cs/
@martin-stastny
Translated using Weblate (Czech)
604e99c 
Currently translated at 80.0% (185 of 231 strings)

Translation: AppCenter/AppCenter
Translate-URL: https://l10n.elementary.io/projects/appcenter/appcenter/cs/
@p-bo
Translated using Weblate (Czech)
3ee872a 
Currently translated at 80.0% (185 of 231 strings)

Translation: AppCenter/AppCenter
Translate-URL: https://l10n.elementary.io/projects/appcenter/appcenter/cs/
Translated using Weblate (Czech)
af3a296 
Currently translated at 80.0% (185 of 231 strings)

Translation: AppCenter/AppCenter
Translate-URL: https://l10n.elementary.io/projects/appcenter/appcenter/cs/
@martin-stastny
Translated using Weblate (Czech)
5cbc3bf 
Currently translated at 80.5% (186 of 231 strings)

Translation: AppCenter/AppCenter
Translate-URL: https://l10n.elementary.io/projects/appcenter/appcenter/cs/
@p-bo
Translated using Weblate (Czech)
25c7f4c 
Currently translated at 80.5% (186 of 231 strings)

Translation: AppCenter/AppCenter
Translate-URL: https://l10n.elementary.io/projects/appcenter/appcenter/cs/
Translated using Weblate (Czech)
8a3349a 
Currently translated at 80.5% (186 of 231 strings)

Translation: AppCenter/AppCenter
Translate-URL: https://l10n.elementary.io/projects/appcenter/appcenter/cs/
@filipboucek
Translated using Weblate (Czech)
1f622af 
Currently translated at 89.1% (206 of 231 strings)

Translation: AppCenter/AppCenter
Translate-URL: https://l10n.elementary.io/projects/appcenter/appcenter/cs/
@martin-stastny
Translated using Weblate (Czech)
f7a53a8 
Currently translated at 89.1% (206 of 231 strings)

Translation: AppCenter/AppCenter
Translate-URL: https://l10n.elementary.io/projects/appcenter/appcenter/cs/
@p-bo
Translated using Weblate (Czech)
abefd19 
Currently translated at 89.1% (206 of 231 strings)

Translation: AppCenter/AppCenter
Translate-URL: https://l10n.elementary.io/projects/appcenter/appcenter/cs/
Translated using Weblate (Czech)
519e718 
Currently translated at 90.4% (209 of 231 strings)

Translation: AppCenter/AppCenter
Translate-URL: https://l10n.elementary.io/projects/appcenter/appcenter/cs/
@filipboucek
Translated using Weblate (Czech)
a2cfa32 
Currently translated at 90.4% (209 of 231 strings)

Translation: AppCenter/AppCenter
Translate-URL: https://l10n.elementary.io/projects/appcenter/appcenter/cs/
@p-bo
Translated using Weblate (Czech)
3478858 
Currently translated at 90.4% (209 of 231 strings)

Translation: AppCenter/AppCenter
Translate-URL: https://l10n.elementary.io/projects/appcenter/appcenter/cs/
@p-bo
Translated using Weblate (Czech)
e36e7f7 
Currently translated at 90.4% (209 of 231 strings)

Translation: AppCenter/AppCenter
Translate-URL: https://l10n.elementary.io/projects/appcenter/appcenter/cs/
@martin-stastny
Translated using Weblate (Czech)
579e399 
Currently translated at 90.4% (209 of 231 strings)

Translation: AppCenter/AppCenter
Translate-URL: https://l10n.elementary.io/projects/appcenter/appcenter/cs/
@p-bo
Translated using Weblate (Czech)
9dc86e9 
Currently translated at 68.4% (100 of 146 strings)

Translation: AppCenter/AppCenter (Extra)
Translate-URL: https://l10n.elementary.io/projects/appcenter/extra/cs/
@TomiOhl
Translated using Weblate (Hungarian)
e08eb10 
Currently translated at 100.0% (231 of 231 strings)

Translation: AppCenter/AppCenter
Translate-URL: https://l10n.elementary.io/projects/appcenter/appcenter/hu/
@TomiOhl
Translated using Weblate (Hungarian)
b121894 
Currently translated at 21.2% (31 of 146 strings)

Translation: AppCenter/AppCenter (Extra)
Translate-URL: https://l10n.elementary.io/projects/appcenter/extra/hu/
@p-bo
Translated using Weblate (Czech)
f55488e 
Currently translated at 90.9% (210 of 231 strings)

Translation: AppCenter/AppCenter
Translate-URL: https://l10n.elementary.io/projects/appcenter/appcenter/cs/
@p-bo
Translated using Weblate (Czech)
44eac52 
Currently translated at 100.0% (231 of 231 strings)

Translation: AppCenter/AppCenter
Translate-URL: https://l10n.elementary.io/projects/appcenter/appcenter/cs/
@isantop isantop marked this pull request as ready for review June 29, 2022 19:58
@isantop isantop requested review from a team June 29, 2022 19:58
@n3m0-22 n3m0-22 self-assigned this Jun 29, 2022
@n3m0-22
Copy link

n3m0-22 commented Jun 29, 2022

I'm seeing an issue where the Home and Installed buttons at the top disappear.

Steps to reproduce:

  • Open pop-shop
  • Super + A
  • Right click an application and show details
  • Swipe back or click the home button

The Home and Install buttons at the top will now be gone. This does not seem to happen with all apps, but has happened every time with Signal and Virtualbox. Otherwise all other new functionality is working and testing is passing.

simplescreenrecorder-2022-06-29_14.53.45.mp4

@gangwerz
Copy link

I was able to replicate this behavior with @n3m0-22's instructions in a VM of Pop 22.04

@isantop
Copy link
Author

isantop commented Jul 1, 2022

@n3m0-22 I see what was causing that. Should be fixed as of 114a24b

n3m0-22
n3m0-22 approved these changes Jul 1, 2022
View reviewed changes
Copy link

@n3m0-22 n3m0-22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue has been resolved.

@n3m0-22 n3m0-22 removed their assignment Jul 1, 2022
13r0ck
13r0ck suggested changes Jul 1, 2022
View reviewed changes
src/Views/AppInfoView.vala Show resolved Hide resolved
13r0ck and others added 3 commits July 5, 2022 17:14
@13r0ck @isantop
scale screenshots in carousel responsivly to application width
232c75e
@isantop
fix(AppInfoView): fix incorrect indentation
ff78165
@13r0ck @isantop
Change image resize listener to the header_clamp rather than body
04b6213 
The body clamp was creating a loop where refreshing the image
would then resize the body_clamp, then another resize was sent,
again and again forever. By changing the listener to a container
that spans whe width of the window and doesn't contain the image
(the header being perfect for this) we still get the same
functionality (event when window resizes) without the loop.
@13r0ck 13r0ck self-requested a review July 8, 2022 01:39
@13r0ck 13r0ck requested a review from n3m0-22 July 8, 2022 01:40
n3m0-22
n3m0-22 approved these changes Jul 8, 2022
View reviewed changes
Copy link

@n3m0-22 n3m0-22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Previous issues are still resolved. New features are working properly. All testing passed.

@isantop isantop merged commit 7b95869 into master Jul 8, 2022
@isantop isantop deleted the upstream-rebase branch July 8, 2022 14:50
@jacobgkau jacobgkau mentioned this pull request Jul 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@13r0ck 13r0ck 13r0ck approved these changes

@n3m0-22 n3m0-22 n3m0-22 approved these changes

Assignees

@isantop isantop

Labels
upstream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.