feat: display fancy icons on Windows Terminal #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This change allows to force the usage of the fancy icons via an environment variable, regardless of the current platform. This is because on Windows, the
conhost
shell does not support them by default (unless you change the font), but the Windows Terminal does. I couldn't find a way automatically detect whether or not the current terminal could handle these icons, so I opted for a flag.On
conhost.exe
, some characters were not supported. Because of this, the platform is checked againstwin32
to determine if the usage of these characters is allowed.This change updates that behavior by adding an additional check against the
WT_SESSION
environment variable, in order to allow these characters on the Windows Terminal, which supports them.Sources:
Related:
Types of changes
Checklist