Check sum of migration rates entering a deme are <= 1. #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #249 +/- ##
==========================================
+ Coverage 95.97% 96.11% +0.14%
==========================================
Files 7 7
Lines 1018 1055 +37
==========================================
+ Hits 977 1014 +37
Misses 41 41
Continue to review full report at Codecov.
|
|
I'm going to merge this without fixing the hypothesis strategy. The migration-generating part of that code needs to be updated for symmetric migrations anyway (#216), so I'll add a note about the sum<=1 restriction over there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #244.
Probably needs more tests. I'm also not sure of the best way to avoid hitting this in the hypothesis strategy for generating graphs (but I didn't get any failures yet).