Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix in_generations() with time_units=generations and generation_time. #274

Merged
merged 1 commit into from
Apr 15, 2021

Conversation

grahamgower
Copy link
Member

Closes #273

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grahamgower grahamgower merged commit 9b9a54d into popsim-consortium:main Apr 15, 2021
@grahamgower grahamgower deleted the in_generations branch April 19, 2021 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graph.in_generations() assumes time_units are not generations if generation_time is given.
2 participants