Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some pulse edge cases #362

Merged
merged 4 commits into from
Jul 26, 2021
Merged

Conversation

grahamgower
Copy link
Member

Closes #328 and #357.

@codecov
Copy link

codecov bot commented Jul 23, 2021

Codecov Report

Merging #362 (c462416) into main (0c24b41) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #362   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files           5        5           
  Lines        1502     1502           
=======================================
  Hits         1501     1501           
  Misses          1        1           
Impacted Files Coverage Δ
demes/demes.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c24b41...c462416. Read the comment docs.

@apragsdale
Copy link
Member

apragsdale commented Jul 23, 2021 via email

Copy link
Member

@apragsdale apragsdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good, thanks @grahamgower.

I think it makes sense to go ahead and merge this, and then I'll make the needed changes over in #353. There are a few suggestions that I haven't gotten to there, but with this merged I can do that and sync with this all at once.

@grahamgower grahamgower merged commit 586f073 into popsim-consortium:main Jul 26, 2021
@grahamgower grahamgower deleted the pulse-misc branch August 2, 2021 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graph.assert_close() shouldn't ignore pulse ordering.
2 participants