Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in migration simplification #385

Merged
merged 1 commit into from
Nov 28, 2021

Conversation

apragsdale
Copy link
Member

@apragsdale apragsdale commented Nov 28, 2021

Closes #384. Was a pretty quick bug to find - dest repeated twice instead of both source and dest when checking one end of the migration time interval.

@codecov
Copy link

codecov bot commented Nov 28, 2021

Codecov Report

Merging #385 (e52fc7e) into main (0676cf0) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #385   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files           5        5           
  Lines        1520     1520           
=======================================
  Hits         1518     1518           
  Misses          2        2           
Impacted Files Coverage Δ
demes/demes.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0676cf0...e52fc7e. Read the comment docs.

Copy link
Member

@grahamgower grahamgower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice catch!

@apragsdale apragsdale merged commit 49a2b05 into popsim-consortium:main Nov 28, 2021
@apragsdale apragsdale changed the title Closes #384 Fix bug in migration simplification Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some symmetric migration scenarioes are not simplified
2 participants