fix: yes/no in table stats for boolean fields

popstas · Aug 26, 2020 · 8214c0c · 8214c0c
1 parent e07b95a
commit 8214c0c
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -6,3 +6,6 @@ Demo:
 - [Default report](https://viasite.github.io/site-audit-seo-viewer/?url=https://site-audit.viasite.ru/reports/blog.popstas.ru-default.json)
 - [Lighthouse report](https://viasite.github.io/site-audit-seo-viewer/?url=https://site-audit.viasite.ru/reports/blog.popstas.ru-lighthouse.json)
 - [Default + Basic Lighthouse report](https://viasite.github.io/site-audit-seo-viewer/?url=https://site-audit.viasite.ru/reports/blog.popstas.ru-default-plus-lighthouse.json)
+
+# TODO
+- show diff between reports
diff --git a/components/Stats.vue b/components/Stats.vue
@@ -159,10 +159,15 @@ export default {
           for (let valName in vals) {
             const count = vals[valName];
             let valClass = this.getColumnValidateClass(valName, field.validate);
-            if (valClass == 'danger') validateClass = valClass;
-            else if (valClass == 'warning' && validateClass != 'danger') validateClass = valClass;
+            if (valClass === 'danger') validateClass = valClass;
+            else if (valClass === 'warning' && validateClass !== 'danger') validateClass = valClass;
             else if (!validateClass) validateClass = valClass;
 
+            // TODO: universal renderItemValue, getColumnValue
+            if (field.type === 'boolean') {
+              valName = parseInt(valName) ? 'yes' : 'no'; // tolang
+            }
+
             subvalues.push({
               validateClass: valClass,
               value: valName,

diff --git a/pages/index.vue b/pages/index.vue
@@ -533,7 +533,7 @@ export default {
         valueText = `<img alt="error loading image" style="width: 150px; height: auto;" src="${valueText}" title="${valueText}"/>`;
       }
 
-      if (field.type == "boolean") {
+      if (field.type === 'boolean') {
         valueText = parseInt(valueText) ? "yes" : "no"; // tolang
       }