Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storybook integration #63

Merged
merged 1 commit into from
Feb 11, 2022
Merged

Storybook integration #63

merged 1 commit into from
Feb 11, 2022

Conversation

daniaki
Copy link

@daniaki daniaki commented Feb 11, 2022

Changes

  • Storybook added as a dev dependency
  • React Router migrated to v6 due to this Storybook issue forcing users to upgrade from v5 to v6, which introduced many breaking changes.
  • Project restructure to account for router changes and for general tidiness

Instructions

  • Checkout the storybook branch
  • Run yarn run clean && yarn install to clear existing node modules and force a clean install
  • Run yarn run storybook to see if Storybook works
  • Run yarn run start TOB to see if the main browsers still works

@daniaki daniaki merged commit 4005175 into dev Feb 11, 2022
@daniaki daniaki added this to the MVP milestone Feb 11, 2022
@daniaki daniaki linked an issue Feb 11, 2022 that may be closed by this pull request
Investigate Storybook.js for isolated UI prototyping #56
Closed
@daniaki daniaki deleted the storybook branch February 17, 2022 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielreti danielreti danielreti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
TOB-WGS Browser
Status: Done
Milestone
MVP
Development

Successfully merging this pull request may close these issues.

Investigate Storybook.js for isolated UI prototyping
2 participants
@daniaki @danielreti