Skip to content

Commit

Permalink
[Integration][AWS] Fix wrong parameter name in default mapping (#795)
Browse files Browse the repository at this point in the history
# Description

What - change the "get extra data" parameter to the correct name
(matches the docs)
Why - the prev parameter is not the correct parameter
How - change the name to `useGetResourceAPI` 

## Type of change

Please leave one option from the following and delete the rest:

- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] New Integration (non-breaking change which adds a new integration)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Non-breaking change (fix of existing functionality that will not
change current behavior)
- [ ] Documentation (added/updated documentation)

## Screenshots

Include screenshots from your environment showing how the resources of
the integration will look.

## API Documentation

Provide links to the API documentation used for this integration.

---------

Co-authored-by: Shalev Avhar <shalev@getport.io>
  • Loading branch information
shalev007 and Shalev Avhar authored Jul 10, 2024
1 parent b7e9438 commit 87ed924
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 4 deletions.
8 changes: 5 additions & 3 deletions integrations/aws/.port/resources/port-app-config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ resources:
- kind: AWS::S3::Bucket
selector:
query: 'true'
useGetResource: 'true'
useGetResourceAPI: 'true'
port:
entity:
mappings:
Expand All @@ -27,7 +27,9 @@ resources:
blueprint: '"cloudResource"'
properties:
kind: .__Kind
region: .__Region
region: >-
.Properties.RegionalDomainName |
capture(".*\\.(?<region>[^\\.]+)\\.amazonaws\\.com") | .region
tags: .Properties.Tags
arn: .Properties.Arn
link: '.Properties | select(.Arn != null) | "https://console.aws.amazon.com/go/view?arn=" + .Arn'
Expand All @@ -53,7 +55,7 @@ resources:
- kind: AWS::ECS::Cluster
selector:
query: 'true'
useGetResource: 'true'
useGetResourceAPI: 'true'
port:
entity:
mappings:
Expand Down
7 changes: 7 additions & 0 deletions integrations/aws/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

<!-- towncrier release notes start -->

# Port_Ocean 0.2.12 (2024-07-09)

### Improvements

- Fix default useGetResourceAPI property name (#1)
- Use by default the actual S3 Bucket region instead of default region used to fetch it (#2)

# Port_Ocean 0.2.11 (2024-07-09)

### Improvements
Expand Down
2 changes: 1 addition & 1 deletion integrations/aws/pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "aws"
version = "0.2.11"
version = "0.2.12"
description = "This integration will map all your resources in all the available accounts to your Port entities"
authors = ["Shalev Avhar <shalev@getport.io>", "Erik Zaadi <erik@getport.io>"]

Expand Down

0 comments on commit 87ed924

Please sign in to comment.