Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GoogleCloud] Real time improvements + Susbscription as specific resource #1010

Merged
merged 11 commits into from
Sep 15, 2024

Conversation

matan84
Copy link
Member

@matan84 matan84 commented Sep 11, 2024

Description - Real time improvements

What - Changed default resource realtime data + Changed real time calculation of deleted entities

Why - Remove redundant unreliable calls to the GCP's Asset inventory

How - Use the asset data for the current upserted non-specific kind + in delete use the prior state of the asset's resource

Description - Added subscription specific handling

What - Added subscription as specific kind we get from the api and not from the asset inventory

Why - Inconsistent behavior with asset inventory - Very late updates of inventory + not full data on real time events

How - added subscriber api that will be able to perform list_subscriptions + get_subscription

Type of change

Please leave one option from the following and delete the rest:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New Integration (non-breaking change which adds a new integration)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Non-breaking change (fix of existing functionality that will not change current behavior)
  • Documentation (added/updated documentation)

All tests should be run against the port production environment(using a testing org).

Core testing checklist

  • Integration able to create all default resources from scratch
  • Resync finishes successfully
  • Resync able to create entities
  • Resync able to update entities
  • Resync able to detect and delete entities
  • Scheduled resync able to abort existing resync and start a new one
  • Tested with at least 2 integrations from scratch
  • Tested with Kafka and Polling event listeners
  • Tested deletion of entities that don't pass the selector

Integration testing checklist

  • Integration able to create all default resources from scratch
  • Resync able to create entities
  • Resync able to update entities
  • Resync able to detect and delete entities
  • Resync finishes successfully
  • If new resource kind is added or updated in the integration, add example raw data, mapping and expected result to the examples folder in the integration directory.
  • If resource kind is updated, run the integration with the example data and check if the expected result is achieved
  • If new resource kind is added or updated, validate that live-events for that resource are working as expected
  • Docs PR link here

Preflight checklist

  • Handled rate limiting
  • Handled pagination
  • Implemented the code in async
  • Support Multi account

Screenshots

Include screenshots from your environment showing how the resources of the integration will look.

API Documentation

Provide links to the API documentation used for this integration.

@matan84 matan84 requested a review from a team as a code owner September 11, 2024 06:28
integrations/gcp/main.py Outdated Show resolved Hide resolved
@matan84 matan84 merged commit 119cf98 into main Sep 15, 2024
15 checks passed
@matan84 matan84 deleted the gcp-integration-improvements branch September 15, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants