-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Integration][ADO] Added Support for boards and columns #1034
[Integration][ADO] Added Support for boards and columns #1034
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. just some comments
} | ||
}, | ||
{ | ||
"identifier": "column", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's make the identifier consistent with the others azureDevopsBoard
, azureDevopsColumn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The none of the kinds in the default blueprint has this prefix azureDevops
yield [ | ||
{ | ||
**column, | ||
"__board_id": board.get("id"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return the full board data instead of just the id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
"__board_id": board.get("id"), | ||
"__project": board.get("__project"), | ||
} | ||
for column in board.get("columns", []) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see how this will fit in since the boards API return only name, id and url. How do we get the columns to be returned as part of the boards?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is another function that enriches the data on line 273
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mainly add tests, looks good
integrations/azure-devops/azure_devops/client/azure_devops_client.py
Outdated
Show resolved
Hide resolved
integrations/azure-devops/azure_devops/client/azure_devops_client.py
Outdated
Show resolved
Hide resolved
…ent.py Co-authored-by: Matan <51418643+matan84@users.noreply.github.com>
…ent.py Co-authored-by: Matan <51418643+matan84@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
What - Added functionality to fetch boards and their respective columns from Azure DevOps.
Why - This feature is necessary to support synchronization of Azure DevOps boards and their columns, allowing for more detailed management and tracking of board data within the system.
How - Implemented a method that fetches boards from Azure DevOps and retrieves their columns. The method also handles cases where the
columns
field may be missing from the board, ensuring that the system does not break when such cases occur.Type of change
Please leave one option from the following and delete the rest:
All tests should be run against the port production environment(using a testing org).
Core testing checklist
Integration testing checklist
examples
folder in the integration directory.Preflight checklist
Screenshots
Include screenshots from your environment showing how the resources of the integration will look.
API Documentation
Provide links to the API documentation used for this integration.
Columns Documentation
Board Documentation