Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitlabtestv2 #1039

Closed
wants to merge 7 commits into from
Closed

Gitlabtestv2 #1039

wants to merge 7 commits into from

Conversation

dsbtek
Copy link

@dsbtek dsbtek commented Sep 20, 2024

Description

What - Updated GitLab integration to correct entity mappings for group, merge-request, issues, and projects. Adjusted blueprint identifiers and ensured alignment with GitLab API specifications to prevent sync failures.

Why - Previous resync attempts were failing due to incorrect mappings and relation definitions, leading to failed tasks during the entity upsert process.

How - Refined the port-app-config.yaml file to update the entity mappings and relations. Tested resync processes to ensure that entities are created, updated, and deleted correctly.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Core testing checklist

  • Integration able to create all default resources from scratch
  • Resync finishes successfully
  • Resync able to create entities
  • Resync able to update entities
  • Resync able to detect and delete entities
  • Scheduled resync able to abort existing resync and start a new one
  • Tested with at least 2 integrations from scratch
  • Tested with Kafka and Polling event listeners
  • Tested deletion of entities that don't pass the selector

Integration testing checklist

  • Integration able to create all default resources from scratch
  • Resync able to create entities
  • Resync able to update entities
  • Resync able to detect and delete entities
  • Resync finishes successfully
  • If new resource kind is added or updated in the integration, add example raw data, mapping and expected result to the examples folder in the integration directory.
  • If resource kind is updated, run the integration with the example data and check if the expected result is achieved
  • If new resource kind is added or updated, validate that live-events for that resource are working as expected
  • Docs PR link here

Preflight checklist

  • Handled rate limiting
  • Handled pagination
  • Implemented the code in async
  • Support Multi account

Screenshots

(Include screenshots here)

API Documentation

(Provide links to the GitLab API documentation used for this integration)

dsbtek and others added 7 commits September 16, 2024 13:44
Features Added:
Integrated GitLab API to retrieve merge requests, issues, groups, and projects.
Set up a webhook to capture and process GitLab-triggered events.
…configuration

- Removed unnecessary "python" field from test-integration launch configuration in `launch.json` as part of review feedback.
- Ensured configurations are streamlined without redundant fields.
- Added error handling for `httpcore.ReadTimeout` to prevent integration failure when retrieving projects from GitLab's API.
- Modified the `_paginated_request` method to gracefully handle timeouts and retry the request.
- Adjusted the timeout configuration for GitLab API requests to improve reliability when fetching large datasets.
- Updated relevant logging to provide better visibility during pagination and request retries.
- Adjusted entity mappings in the port-app-config.yaml to ensure correct data retrieval for groups, merge requests, issues, and projects.
- Ensured that the blueprint identifiers are accurately referenced for each entity type.
- Verified that the properties and relations align with the GitLab API specifications to prevent sync failures.

This change aims to resolve the recent resync issues encountered during the integration process.
@PeyGis PeyGis closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants