-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Framework] Port 8572 ocean startup when saas #697
Conversation
…up-when-Saas # Conflicts: # CHANGELOG.md # port_ocean/core/defaults/initialize.py # pyproject.toml
…up-when-Saas # Conflicts: # CHANGELOG.md # pyproject.toml
…up-when-Saas # Conflicts: # CHANGELOG.md
port_ocean/core/utils.py
Outdated
raise Exception( | ||
f"Can't run {current_runtime} integration in {requested_runtime} runtime" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use custom exception that inherit ocean exceptions
pyproject.toml
Outdated
@@ -1,6 +1,6 @@ | |||
[tool.poetry] | |||
name = "port-ocean" | |||
version = "0.7.1" | |||
version = "0.7.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its a new feature therefore it should be a new minor
…up-when-Saas # Conflicts: # CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small comment
and update the changelog date
port_ocean/core/utils.py
Outdated
current_integration = await port_client.get_current_integration(should_raise=False) | ||
current_runtime = current_integration.get("installationType", "OnPrem") | ||
if current_integration and current_runtime != requested_runtime: | ||
raise OceanAbortException( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ocean abort exception are for resyncs
can you create a new dedicated exception derived from BaseOceanException?
async def validate_integration_runtime( | ||
port_client: PortClient, requested_runtime: Runtime | ||
) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe add a debug log
CHANGELOG.md
Outdated
@@ -7,6 +7,13 @@ this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm | |||
|
|||
<!-- towncrier release notes start --> | |||
|
|||
## 0.9.0 (2024-06-18) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update the date
port_ocean/core/utils.py
Outdated
current_runtime = current_integration.get("installationType", "OnPrem") | ||
if current_integration and current_runtime != requested_runtime: | ||
raise OceanAbortException( | ||
f"Can't run {requested_runtime} integration in {current_runtime} runtime" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be more precise and verbose
…up-when-Saas # Conflicts: # CHANGELOG.md
Description
What - handle startup when running as saas
Type of change
Please leave one option from the following and delete the rest:
Screenshots
Include screenshots from your environment showing how the resources of the integration will look.
API Documentation
Provide links to the API documentation used for this integration.