[Framework] Always initialize port default mappings in case where no other mapping is configured #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yairsimantov20
requested changes
Jun 9, 2024
| @@ -73,7 +73,8 @@ async def _initialize_required_integration_settings( | |||
| port_app_config=default_mapping, | |||
| ) | |||
| except httpx.HTTPStatusError as err: | |||
| raise Exception(f"Failed to apply default mapping: {err.response.text}.") | |||
| logger.error("Failed to apply default mapping") | |||
There was a problem hiding this comment.
Suggested change
| logger.error("Failed to apply default mapping") | |
| logger.error(f"Failed to apply default mapping: {err.response.text}.") |
There was a problem hiding this comment.
that was the previous state, don't think it's needed to both log the error text and raise the whole exception
There was a problem hiding this comment.
The whole exception wont log the response text
Tankilevitch
changed the title
Tankilevitch
requested changes
Jun 9, 2024
yairsimantov20
approved these changes
Jun 10, 2024
omby8888
deleted the
PORT-7599-Ocean-Run-Once-with-initialize_port_resources-false-doesn-t-sync-resources
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What - Always initialize port default mappings in case where no other mapping is configured
Why - Integration that initializes with empty mapping wont do enything in resync and will cause confusion with our clients, furthermore integration that runs 'ONCE' will take no effect with initializeportresources=false
How - reorder the initialization proccess
Type of change
Please leave one option from the following and delete the rest:
Screenshots
Include screenshots from your environment showing how the resources of the integration will look.
API Documentation
Provide links to the API documentation used for this integration.