Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PORT-8828] [AWS] Ensure default region for global resources #761

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

erikzaadi
Copy link
Member

Description

What - Ensure that there's a default region for global AWS resources
Why - Creating an instance of the cloudcontrol client would fail if no AWS default region was known
How - Lookup default regions from the credentials

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Copy link
Member

@matan84 matan84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, add a changelog + version bump in the pyproject.toml .

integrations/aws/utils/aws.py Outdated Show resolved Hide resolved
integrations/aws/utils/aws.py Outdated Show resolved Hide resolved
@erikzaadi erikzaadi changed the title Ensure default region for global resources [PORT-8828] [AWS] Ensure default region for global resources Jul 2, 2024
@erikzaadi erikzaadi added integration A change in integration files integration-aws Changes related to the aws integration labels Jul 2, 2024
@github-actions github-actions bot added size/M and removed size/S labels Jul 2, 2024
@erikzaadi erikzaadi merged commit 87c6a59 into main Jul 2, 2024
7 checks passed
@erikzaadi erikzaadi deleted the PORT-8828 branch July 2, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration A change in integration files integration-aws Changes related to the aws integration size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants