Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Integration][AWS] use the same event loop for all threads #949

Merged

Conversation

shalev007
Copy link
Contributor

@shalev007 shalev007 commented Aug 26, 2024

Since running on new event loops got us Semaphore is bound to a different event loop error

Description

What - fix Semaphore is bound to a different event loop
Why - all Semaphore were used in different event loops and once the thread ended the Semaphore could not run in a different event loop
How - use the same event loop across all threads

Type of change

Please leave one option from the following and delete the rest:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New Integration (non-breaking change which adds a new integration)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Non-breaking change (fix of existing functionality that will not change current behavior)
  • Documentation (added/updated documentation)

Core testing checklist

  • Integration able to create all default resources from scratch
  • Resync finishes successfully
  • Resync able to create entities
  • Resync able to update entities
  • Resync able to detect and delete entities
  • Scheduled resync able to abort existing resync and start a new one
  • Tested with at least 2 integrations from scratch
  • Tested with Kafka and Polling event listeners

Since running on new event loops got us Semaphore is bound to a different event loop error
@shalev007 shalev007 requested a review from a team as a code owner August 26, 2024 15:03
Copy link
Contributor

@Tankilevitch Tankilevitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

holding

@shalev007 shalev007 changed the title fix: use the same event loop for all threads [Integration][AWS] use the same event loop for all threads Aug 27, 2024
@shalev007
Copy link
Contributor Author

Add changelog and bump version

@shalev007 shalev007 merged commit cf0627f into main Aug 28, 2024
12 checks passed
@shalev007 shalev007 deleted the PORT-10065-ocean-core-coroutine-bound-to-a-different-event-loop branch August 28, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants