[Framework] Fix bug search relation error unhashable dict #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talsabagport
requested changes
Aug 27, 2024
| Entity.parse_obj(result["entity"]) if result.get("entity") else entity | ||
| ) | ||
|
|
||
| result_entity.relations = { |
There was a problem hiding this comment.
Add a comment to explain it
Co-authored-by: talsabagport <tal@getport.io>
…rror-unhashable-dict' into PORT-10064-Bug-search-relation-error-unhashable-dict
talsabagport
approved these changes
Aug 27, 2024
Tankilevitch
requested changes
Aug 27, 2024
Comment on lines
+61
to
+62
| result_entity = ( | ||
| Entity.parse_obj(result["entity"]) if result.get("entity") else entity |
There was a problem hiding this comment.
returning all the result entity means that we return the full entity that is inside port, this means that if we just ingested the relations of an entity but it has 20 more properties it will be returned here and passed forward to the resync phase. This can be problematic from a memory point of view and that is why we only took the identifier and the relations from the result entity and not the full entity.
There was a problem hiding this comment.
we need the blueprint as well to delete the identifier of a specific blueprint only as there may be entities with same identifier but different blueprints
Tankilevitch
changed the title
…-relation-error-unhashable-dict # Conflicts: # CHANGELOG.md
omby8888
deleted the
PORT-10064-Bug-search-relation-error-unhashable-dict
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What - Refer to entity key in upsert entity response, if the response is not 200 then turn raw search relations into None to not harm the deletion proccess
Why - Response from upsert entity api isn't processed right and causes ocean core to use the raw entity that contains dict typed relations instead of string which is the relation's entity identifier
How - refer to the entity key in a response that looks like {ok: true, entity: {...}}, if the response is not 200 turn the dict typed relations into None
Type of change
Please leave one option from the following and delete the rest:
All tests should be run against the port production environment(using a testing org).
Core testing checklist
Integration testing checklist
examplesfolder in the integration directory.Preflight checklist
Screenshots
Include screenshots from your environment showing how the resources of the integration will look.
API Documentation
Provide links to the API documentation used for this integration.