fix(behavior): make EditorSnapshot.selection nullable

This is a bit annoying, but more correct. And the `selection` is already
nullable in the selectors.

packages/editor/src/behaviors/behavior.core.lists.ts

@@ -25,7 +25,7 @@ const clearListOnBackspace = defineBehavior({
 
     const atTheBeginningOfBLock =
       focusTextBlock.node.children[0]._key === focusSpan.node._key &&
-      context.selection.focus.offset === 0
+      context.selection?.focus.offset === 0
 
     if (atTheBeginningOfBLock && focusTextBlock.node.level === 1) {
       return {focusTextBlock}
@@ -57,7 +57,7 @@ const unindentListOnBackspace = defineBehavior({
 
     const atTheBeginningOfBLock =
       focusTextBlock.node.children[0]._key === focusSpan.node._key &&
-      context.selection.focus.offset === 0
+      context.selection?.focus.offset === 0
 
     if (
       atTheBeginningOfBLock &&

packages/editor/src/behaviors/behavior.markdown.ts

@@ -57,7 +57,7 @@ export function createMarkdownBehaviors(config: MarkdownBehaviorsConfig) {
             'children',
             {_key: focusSpan.node._key},
           ],
-          offset: context.selection.focus.offset,
+          offset: context.selection?.focus.offset ?? 0,
         },
       })
 
@@ -245,7 +245,7 @@ export function createMarkdownBehaviors(config: MarkdownBehaviorsConfig) {
             'children',
             {_key: focusSpan.node._key},
           ],
-          offset: context.selection.focus.offset,
+          offset: context.selection?.focus.offset ?? 0,
         },
       })
 
@@ -319,7 +319,7 @@ export function createMarkdownBehaviors(config: MarkdownBehaviorsConfig) {
 
       const atTheBeginningOfBLock =
         focusTextBlock.node.children[0]._key === focusSpan.node._key &&
-        context.selection.focus.offset === 0
+        context.selection?.focus.offset === 0
 
       const defaultStyle = config.defaultStyle?.(context)
 
@@ -368,7 +368,7 @@ export function createMarkdownBehaviors(config: MarkdownBehaviorsConfig) {
             'children',
             {_key: focusSpan.node._key},
           ],
-          offset: context.selection.focus.offset,
+          offset: context.selection?.focus.offset ?? 0,
         },
       })
 

packages/editor/src/editor/editor-machine.ts

@@ -182,7 +182,7 @@ export const editorMachine = setup({
       schema: EditorSchema
       readOnly: boolean
       maxBlocks: number | undefined
-      selection: NonNullable<EditorSelection> | undefined
+      selection: EditorSelection
       value: Array<PortableTextBlock> | undefined
     },
     events: {} as InternalEditorEvent,
@@ -275,23 +275,6 @@ export const editorMachine = setup({
         context.schema,
       )
 
-      if (!selection) {
-        console.warn(
-          `Unable to handle event ${event.type} due to missing selection`,
-        )
-
-        if (!defaultAction) {
-          return
-        }
-
-        enqueue.raise({
-          type: 'behavior action intends',
-          editor: event.editor,
-          actionIntends: [defaultAction],
-        })
-        return
-      }
-
       const editorContext = {
         keyGenerator: context.keyGenerator,
         schema: context.schema,
@@ -361,7 +344,7 @@ export const editorMachine = setup({
     keyGenerator: input.keyGenerator,
     pendingEvents: [],
     schema: input.schema,
-    selection: undefined,
+    selection: null,
     readOnly: input.readOnly ?? false,
     maxBlocks: input.maxBlocks,
     value: input.value,
@@ -410,7 +393,7 @@ export const editorMachine = setup({
     'error': {actions: emit(({event}) => event)},
     'selection': {
       actions: [
-        assign({selection: ({event}) => event.selection ?? undefined}),
+        assign({selection: ({event}) => event.selection}),
         emit(({event}) => event),
       ],
     },

packages/editor/src/editor/editor-selector.ts

@@ -1,5 +1,4 @@
 import {useSelector} from '@xstate/react'
-import type {EditorSelection} from '../types/editor'
 import type {Editor} from './create-editor'
 import type {EditorSnapshot} from './editor-snapshot'
 import {getValue} from './get-value'
@@ -11,18 +10,7 @@ function defaultCompare<T>(a: T, b: T) {
 /**
  * @alpha
  */
-export type EditorSelectorSnapshot = {
-  context: Omit<EditorSnapshot['context'], 'selection'> & {
-    selection?: NonNullable<EditorSelection>
-  }
-}
-
-/**
- * @alpha
- */
-export type EditorSelector<TSelected> = (
-  snapshot: EditorSelectorSnapshot,
-) => TSelected
+export type EditorSelector<TSelected> = (snapshot: EditorSnapshot) => TSelected
 
 /**
  * @alpha

packages/editor/src/editor/editor-snapshot.ts

@@ -8,7 +8,7 @@ import type {EditorSchema} from './define-schema'
 export type EditorContext = {
   keyGenerator: () => string
   schema: EditorSchema
-  selection: NonNullable<EditorSelection>
+  selection: EditorSelection
   value: Array<PortableTextBlock>
 }
 

packages/editor/src/index.ts

@@ -37,11 +37,7 @@ export {
   useEditor,
   type EditorProviderProps,
 } from './editor/editor-provider'
-export {
-  useEditorSelector,
-  type EditorSelector,
-  type EditorSelectorSnapshot,
-} from './editor/editor-selector'
+export {useEditorSelector, type EditorSelector} from './editor/editor-selector'
 export type {EditorContext, EditorSnapshot} from './editor/editor-snapshot'
 export {usePortableTextEditor} from './editor/hooks/usePortableTextEditor'
 export {usePortableTextEditorSelection} from './editor/hooks/usePortableTextEditorSelection'

packages/editor/src/selectors/index.ts

@@ -1,7 +1,4 @@
-export type {
-  EditorSelector,
-  EditorSelectorSnapshot,
-} from '../editor/editor-selector'
+export type {EditorSelector} from '../editor/editor-selector'
 export type {EditorContext, EditorSnapshot} from '../editor/editor-snapshot'
 export type {
   EditorSelection,